-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed variables in UML diagrams and comments #914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you look into the failed powerflow messages, like I mentioned in the issue?
We talked about this and I maybe you can shed a bit more light on what changed there (at least to me). |
@danielfeismann @marvinheintze It used to be the case that failed power flow events were counted by the scheduler. Nowadays the |
Signed-off-by: Sebastian Peter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just realized that the message is still called CompletionMessage
for external simulations. Just corrected it myself, and the rest should be dealt with by #898 (thus you can just leave ExtEvSimulationClasses.puml
the way it is).
For my comments below, please just reach out right away if I can assist you with the adaptations. It's probably a bit overwhelming when you just started out working on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adapting the initialization diagram, looks great!
Could you adapt all other files in the same fashion as well? Please let me know if you have questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now there's only a changelog entry missing and we're good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message should be "Changelog entry"
825be30
to
6bc5def
Compare
2791b93
to
baf97f8
Compare
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, thanks!
Resolves #675
Renamed
ActivityStartTrigger to Activation,
ScheduleTriggerMessage to ScheduleActivation,
CompletionMessage to Completion
in UML diagrams and in comments.